Worst Smells and Their Worst Reasons

03/17/2021
by   Davide Falessi, et al.
0

The aims of this paper are: 1) to identify "worst smells", i.e., bad smells that never have a good reason to exist, 2) to determine the frequency, change-proneness, and severity associated with worst smells, and 3) to identify the "worst reasons", i.e., the reasons for introducing these worst smells in the first place. To achieve these aims we ran a survey with 71 developers. We learned that 80 out of 314 catalogued code smells are "worst"; that is, developers agreed that these 80 smells should never exist in any code base. We then checked the frequency and change-proneness of these worst smells on 27 large Apache open-source projects. Our results show insignificant differences, in both frequency and change proneness, between worst and non-worst smells. That is to say, these smells are just as damaging as other smells, but there is never any justifiable reason to introduce them. Finally, in follow-up phone interviews with five developers we confirmed that these smells are indeed worst, and the interviewees proposed seven reasons for why they may be introduced in the first place. By explicitly identifying these seven reasons, project stakeholders can, through quality gates or reviews, ensure that such smells are never accepted in a code base, thus improving quality without compromising other goals such as agility or time to market.

READ FULL TEXT
research
12/20/2019

On The Effect Of Code Review On Code Smells

Code smells are symptoms of poor design quality. Since code review is a ...
research
07/29/2021

Developers perception on the severity of test smells: an empirical study

Unit testing is an essential component of the software development life-...
research
02/20/2018

Relative Worst-Order Analysis: A Survey

Relative worst-order analysis is a technique for assessing the relative ...
research
06/22/2020

Multitasking Across Industry Projects: A Replication Study

Background: Multitasking is usual in software development. It is the abi...
research
01/16/2018

Why and How Java Developers Break APIs

Modern software development depends on APIs to reuse code and increase p...
research
01/26/2021

Using a Balanced Scorecard to Identify Opportunities to Improve Code Review Effectiveness: An Industrial Experience Report

Peer code review is a widely adopted software engineering practice to en...
research
06/11/2022

Is Kernel Code Different From Non-Kernel Code? A Case Study of BSD Family Operating Systems

Code churn and code velocity describe the evolution of a code base. Curr...

Please sign up or login with your details

Forgot password? Click here to reset